feat: dae trace #435

jschwinger233 · 2024-01-20T10:24:32Z

Background

This PR adds new subcommand dae trace to observe skb on the system.

dae $ ./dae trace -h
To trace traffic

Usage:
  dae trace [flags]

Flags:
  -h, --help              help for trace
  -4, --ipv4              Capture IPv4 traffic
  -6, --ipv6              Capture IPv6 traffic
  -p, --l4-proto string   Layer 4 protocol (default "tcp")
  -o, --output string     Output file (default "/dev/stdout")
  -P, --port int          Port (default 80)

For example, running dae trace -4 -p tcp -P 233 gives:

dae $ sudo ./dae trace -4 -p tcp -P 80
attaching kprobes: 1704/1704
start tracing
ffff92132a71d8e8 mark=0 netns=4026531840 if=0() proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=65476 ip_local_out
ffff92132a71d8e8 mark=0 netns=4026531840 if=0() proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=65476 __ip_local_out
ffff92132a71d8e8 mark=0 netns=4026531840 if=0() proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 nf_hook_slow
ffff92132a71d8e8 mark=0 netns=4026531840 if=0() proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 ip_output
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 nf_hook_slow
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 apparmor_ip_postroute
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 ip_finish_output
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 __ip_finish_output
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 ip_finish_output2
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 __dev_queue_xmit
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 qdisc_pkt_len_init
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 netdev_core_pick_tx
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 sch_direct_xmit
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 validate_xmit_skb_list
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 validate_xmit_skb
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 netif_skb_features
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 passthru_features_check
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 skb_network_protocol
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 skb_csum_hwoffload_help
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 validate_xmit_xfrm
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 dev_hard_start_xmit
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=141081(curl) 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 skb_clone_tx_timestamp
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=0() 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 dev_kfree_skb_any_reason
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=0() 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 kfree_skb_reason(SKB_CONSUMED)
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=0() 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 skb_release_head_state
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=0() 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 tcp_wfree
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=0() 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 skb_release_data
ffff92132a71d8e8 mark=0 netns=4026531840 if=2(enp0s31f6) proc=0() 10.0.0.6:47812 > 1.1.1.1:80 tcp_flags=S payload_len=0 kfree_skbmem

Notes:

The binary size has increased less than 1M, so I presume it's acceptable.
trace.c has to be compiled with specific arch instead of general bpf, so dae trace only supports some arch:

Supported targets:
	386
	amd64
	arm
	arm64
	arm64be
	armbe
	ppc64
	ppc64le
	riscv64
	s390
	s390x
	sparc
	sparc64

Outstanding issues:

Output to a file
Add new bpf header to https://github.com/daeuniverse/dae_bpf_headers: Bump libbpf version: v1.3.0 dae_bpf_headers#1

Checklist

The Pull Request has been fully tested
There's an entry in the CHANGELOGS
There is a user-facing docs PR against https://github.com/daeuniverse/dae

Full Changelogs

[Implement ...]

Issue Reference

Closes #[issue number]

Test Result

mzz2017 · 2024-01-21T03:29:54Z

cmd/trace.go

+		},
+	}
+
+	traceCmd.PersistentFlags().IntVarP(&IPVersion, "ip-version", "v", 4, "IP version")


-v is confusing (verbose/version). Can we use -4 and -6?

jschwinger233 · 2024-01-21T07:17:21Z

Mark "Ready for review" to trigger PR build.

mzz2017

This work is owesome!

sumire88 · 2024-01-27T01:22:21Z

@jschwinger233 thanks for your amazing work. Has this new feature been tested yet?

dae-prow

🧪 Since the PR has been fully tested, please consider merging it.

sumire88 · 2024-01-27T05:32:30Z

All good, let's proceed.

douglarek · 2024-01-27T07:37:02Z

A very interesting feature! Regarding the Go environment variable GOARCH, is that it is not automatically injected for the 'make' command. Would it be better to default to 'go env GOARCH' in 'make' if the user has not set it explicitly?

This will build the `trace` command which dae added few months ago. See <daeuniverse/dae#435> for detail. Co-authored-by: Aleksana <[email protected]>

dae-prow bot assigned jschwinger233 Jan 20, 2024

dae-prow bot added feature not-yet-tested labels Jan 20, 2024

jschwinger233 requested a review from mzz2017 January 20, 2024 10:26

jschwinger233 mentioned this pull request Jan 20, 2024

Bump libbpf version: v1.3.0 daeuniverse/dae_bpf_headers#1

Merged

jschwinger233 force-pushed the gray/tracing branch from 4fdf0a4 to 9b38418 Compare January 20, 2024 18:09

mzz2017 reviewed Jan 21, 2024

View reviewed changes

jschwinger233 force-pushed the gray/tracing branch 3 times, most recently from 3ccd3b0 to cb58b97 Compare January 21, 2024 05:07

jschwinger233 marked this pull request as ready for review January 21, 2024 07:17

jschwinger233 requested a review from a team as a code owner January 21, 2024 07:17

jschwinger233 requested a review from mzz2017 January 21, 2024 07:26

jschwinger233 force-pushed the gray/tracing branch from cb58b97 to da5b5de Compare January 21, 2024 09:14

jschwinger233 added 2 commits January 21, 2024 17:18

Add trace module and trace subcommand

d36ba14

Build with trace only if possible

fe5d8f2

jschwinger233 force-pushed the gray/tracing branch from da5b5de to fe5d8f2 Compare January 21, 2024 09:18

mzz2017 approved these changes Jan 26, 2024

View reviewed changes

Merge branch 'main' into gray/tracing

c9c9777

sumire88 added tested and removed not-yet-tested labels Jan 27, 2024

dae-prow bot approved these changes Jan 27, 2024

View reviewed changes

jschwinger233 merged commit 5f3249b into daeuniverse:main Jan 27, 2024
27 checks passed

douglarek mentioned this pull request Feb 2, 2024

[Bug Report] Unable to compile trace/trace.go for arm64 #453

Closed

3 tasks

dae-prow bot mentioned this pull request Apr 2, 2024

[Release Changelogs] v0.6.0rc1 #490

Closed

dae-prow bot mentioned this pull request Apr 15, 2024

[Release Changelogs] v0.6.0rc2 #501

Closed

dae-prow bot mentioned this pull request Jun 11, 2024

[Release Changelogs] v0.6.0 #534

Closed

oluceps added a commit to oluceps/nixpkgs that referenced this pull request Jun 18, 2024

dae: add missing subcommand trace

a2f0744

This will build the `trace` command which dae added few months ago. See <daeuniverse/dae#435> for detail. Co-authored-by: Aleksana <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: dae trace #435

feat: dae trace #435

jschwinger233 commented Jan 20, 2024 •

edited

Loading

mzz2017 Jan 21, 2024

jschwinger233 commented Jan 21, 2024

mzz2017 left a comment

sumire88 commented Jan 27, 2024

dae-prow bot left a comment

sumire88 commented Jan 27, 2024

douglarek commented Jan 27, 2024

feat: dae trace #435

feat: dae trace #435

Conversation

jschwinger233 commented Jan 20, 2024 • edited Loading

Background

Checklist

Full Changelogs

Issue Reference

Test Result

mzz2017 Jan 21, 2024

Choose a reason for hiding this comment

jschwinger233 commented Jan 21, 2024

mzz2017 left a comment

Choose a reason for hiding this comment

sumire88 commented Jan 27, 2024

dae-prow bot left a comment

Choose a reason for hiding this comment

sumire88 commented Jan 27, 2024

douglarek commented Jan 27, 2024

jschwinger233 commented Jan 20, 2024 •

edited

Loading